Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deactivate embedding on a dashboard #19626

Merged
merged 4 commits into from
Apr 15, 2022
Merged

fix: deactivate embedding on a dashboard #19626

merged 4 commits into from
Apr 15, 2022

Conversation

suddjian
Copy link
Member

@suddjian suddjian commented Apr 8, 2022

SUMMARY

Deletion wasn't getting committed properly. The DAO method calls commit(), so switched to that.

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@suddjian suddjian requested a review from lilykuang April 8, 2022 17:20
@codecov
Copy link

codecov bot commented Apr 8, 2022 •
edited
Loading

Codecov Report

Merging #19626 (47f6b81) into master (6136942) will decrease coverage by 12.80%.
The diff coverage is 50.81%.

❗ Current head 47f6b81 differs from pull request most recent head 07c9678. Consider uploading reports for the commit 07c9678 to get more accurate results

@@             Coverage Diff             @@
##           master   #19626       +/-   ##
===========================================
- Coverage   66.65%   53.85%   -12.81%     
===========================================
  Files        1680     1681        +1     
  Lines       64277    64371       +94     
  Branches     6564     6583       +19     
===========================================
- Hits        42844    34665     -8179     
- Misses      19731    28025     +8294     
+ Partials     1702     1681       -21
Flag Coverage Δ
hive 52.66% <64.91%> (-0.04%) ⬇️
mysql ?
postgres ?
presto 52.51% <64.91%> (-0.04%) ⬇️
python 56.63% <78.94%> (-25.76%) ⬇️
sqlite ?
unit 47.71% <50.87%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ugins/legacy-plugin-chart-chord/src/ReactChord.jsx 0.00% <0.00%> (ø)
...s/legacy-plugin-chart-horizon/src/HorizonChart.jsx 0.00% <0.00%> (ø)
...acy-plugin-chart-paired-t-test/src/PairedTTest.jsx 0.00% <0.00%> (ø)
...rt-parallel-coordinates/src/ParallelCoordinates.js 0.00% <ø> (ø)
...allel-coordinates/src/ReactParallelCoordinates.jsx 0.00% <0.00%> (ø)
...ins/legacy-plugin-chart-partition/src/Partition.js 0.00% <ø> (ø)
...gacy-plugin-chart-partition/src/ReactPartition.jsx 0.00% <0.00%> (ø)
...ins/legacy-plugin-chart-sankey/src/ReactSankey.jsx 0.00% <0.00%> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 51.23% <ø> (ø)
...ontend/src/SqlLab/components/QuerySearch/index.tsx 73.07% <ø> (ø)
... and 321 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6136942...07c9678. Read the comment docs.

@suddjian suddjian merged commit ae70212 into apache:master Apr 15, 2022
@suddjian suddjian deleted the fix-embedded-deletion branch April 15, 2022 23:15
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@suddjian @philipher29
fix: deactivate embedding on a dashboard (apache#19626)
61dbfc5 
* fix tests

* commit it properly

* unnecessary commit, correct type in docstring

* unused import
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilykuang lilykuang lilykuang approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suddjian @lilykuang @mistercrunch